Skip to content

i18n(ja): add missing particle after Markdown links (wo before verbs, wa for subject) - #23273

Merged
qiancai merged 44 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-missing-particle-after-links
Jul 29, 2026
Merged

i18n(ja): add missing particle after Markdown links (wo before verbs, wa for subject)#23273
qiancai merged 44 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-missing-particle-after-links

Conversation

@yahonda

@yahonda yahonda commented Jul 15, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

This PR restores particles that were dropped immediately after Markdown links throughout the Japanese documentation, where machine translation omitted the particle between a link and the following word. It covers the whole top-level docs tree (reviewed in rounds), several subdirectories, and the large reference pages.

Main fix — missing を (object marker) before a verb:

[link text](url)使用して[link text](url)を使用して

Applied only where the link is the direct object of a transitive verb (使用 / 実行 / 参照 / 報告 / 取得 / 指定 / 削除 / 確認 / 作成 …) in an active conjugation (して / すると / する / します / した / できる …). Compound nouns such as [link]機能 (which need no particle) and passive され forms are not touched. Links whose text is itself a full verb phrase (e.g. [サポートを受ける], [バグを報告する]) are also not given a particle — see the scope note below.

Also — missing は / が (topic / subject marker) where the link is the sentence subject:

[Hibernate](https://hibernate.org/orm/)人気のオープンソースJava ORMです。…)は人気の…

…[store-io-pool-size](url) ONに設定されている場合……)がONに設定されている場合…

Also — missing で / に (instrumental / target marker) where the link is the means or the target rather than the object.

Scope: ~2,388 changed lines across ~757 files, including the multi-round sweep of the top-level docs and the large reference pages (system-variables, tikv-configuration-file, tidb-configuration-file, pd-control, optimizer-hints, sql-plan-management, sql-tuning-best-practice, latency-breakdown, statistics, alert-rules). Verified mechanically: each changed line differs from its original by the restored particle alone, except for the small number of shared lines noted below. No double particle is introduced.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Note on scope — lines shared with sibling ja PRs

A few lines in this PR also carry a fix that belongs to one of the sibling ja i18n PRs (a stray-digit removal, a scrambled-sentence repair, or a code-span particle). Where a later sweep found additional damage on a line this PR already edits, the union of both fixes was applied here — and made byte-identical in the sibling PR — so the two PRs stay conflict-free instead of colliding. For example:

-…発生します。1パラメータ`gc.max_write_bytes_per_sec`使用すると、…
+…発生します。`gc.max_write_bytes_per_sec`パラメータを使用すると、…

Here the stray 1 (a translation-tool placeholder) and the word order were repaired alongside this PR's particle insertion.

Kept out of this PR

To keep this PR strictly to particle insertions, two things were deliberately excluded during review:

  • API-name formatting (TiDB OperatorAPITiDB Operator API, and restoring English CRD names such as TidbCluster, TidbMonitor) was split into its own PR (i18n(ja): keep TiDB Operator API resource names in English #23367).
  • Redundant trailing verbs after support/report links — links whose text is already a full verb phrase ([サポートを受ける](/support.md), [バグを報告する](…/support)) are left untouched here (they need a rewrite, not a particle) and are handled by a dedicated PR. An earlier revision of this PR had wrongly inserted after these links (報告するを参照…); those insertions were reverted.

Rebase / merge state

This PR is rebased onto the current i18n-ja-release-8.5 (which now includes #23272) and merges cleanly. The other open ja i18n PRs are still on the earlier base and will each be rebased onto the current base in turn.

@ti-chi-bot

ti-chi-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. labels Jul 15, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hfxsd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request systematically improves the Japanese documentation by correcting grammatical particles, specifically ensuring the proper use of 'を参照してください' and 'を使用することをお勧めします' across numerous files. The reviewer's feedback is excellent and highly actionable, identifying several remaining typos (such as stray numbers '5', '1', '17'), grammatical awkwardness, missing particles, inconsistent terminology (e.g., 'storage' vs. 'ストレージ'), and minor formatting issues. All suggested changes are accompanied by ready-to-commit code blocks to ensure high-quality, natural Japanese documentation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread CONTRIBUTING.md Outdated
Comment thread ai/guides/join-queries.md Outdated
Comment thread alert-rules.md Outdated
Comment thread alert-rules.md Outdated
Comment thread cached-tables.md Outdated
Comment thread develop/dev-guide-vector-search.md Outdated
Comment thread develop/java-app-best-practices.md Outdated
Comment thread develop/java-app-best-practices.md Outdated
Comment thread dr-secondary-cluster.md Outdated
Comment thread dumpling-overview.md Outdated
yahonda added a commit to yahonda/docs that referenced this pull request Jul 15, 2026
…ingcap#23273)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/docs that referenced this pull request Jul 15, 2026
…, spaces, storage, IAM typo)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yahonda

yahonda commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

Thanks for the thorough review. To keep this PR focused on its single purpose (adding the missing particle after Markdown links), the 34 review findings have been addressed in separate PRs by kind, per our PR-splitting strategy:

These sibling PRs share some files with this one and will be rebased after the earlier PRs merge.

@yahonda
yahonda force-pushed the fix-ja-missing-particle-after-links branch from 7cfd082 to 6244b84 Compare July 15, 2026 08:06
yahonda added a commit to yahonda/docs that referenced this pull request Jul 16, 2026
…ingcap#23273)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/docs that referenced this pull request Jul 16, 2026
…, spaces, storage, IAM typo)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yahonda
yahonda force-pushed the fix-ja-missing-particle-after-links branch from a0f87a4 to 84b240b Compare July 16, 2026 00:38
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 16, 2026
@yahonda
yahonda force-pushed the fix-ja-missing-particle-after-links branch from 84b240b to 452ea4b Compare July 16, 2026 09:05
yahonda added a commit to yahonda/docs that referenced this pull request Jul 16, 2026
…ingcap#23273)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/docs that referenced this pull request Jul 16, 2026
…, spaces, storage, IAM typo)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/docs that referenced this pull request Jul 21, 2026
…, spaces, storage, IAM typo)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/docs that referenced this pull request Jul 21, 2026
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275).
Each PR previously applied only its own fix, so whichever merged second would
conflict. Apply the union of the fixes (stray-digit removal + particle insertion)
so every branch produces identical text and merges cleanly in any order.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/docs that referenced this pull request Jul 21, 2026
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275).
Each PR previously applied only its own fix, so whichever merged second would
conflict. Apply the union of the fixes (stray-digit removal + particle insertion)
so every branch produces identical text and merges cleanly in any order.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/docs that referenced this pull request Jul 21, 2026
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275).
Each PR previously applied only its own fix, so whichever merged second would
conflict. Apply the union of the fixes (stray-digit removal + particle insertion)
so every branch produces identical text and merges cleanly in any order.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/docs that referenced this pull request Jul 21, 2026
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275).
Each PR previously applied only its own fix, so whichever merged second would
conflict. Apply the union of the fixes (stray-digit removal + particle insertion)
so every branch produces identical text and merges cleanly in any order.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ebba8651-6379-41f9-8fed-0adc0d420bf6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

yahonda added a commit to yahonda/docs that referenced this pull request Jul 21, 2026
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275).
Each PR previously applied only its own fix, so whichever merged second would
conflict. Apply the union of the fixes (stray-digit removal + particle insertion)
so every branch produces identical text and merges cleanly in any order.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/docs that referenced this pull request Jul 21, 2026
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275).
Each PR previously applied only its own fix, so whichever merged second would
conflict. Apply the union of the fixes (stray-digit removal + particle insertion)
so every branch produces identical text and merges cleanly in any order.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yahonda
yahonda force-pushed the fix-ja-missing-particle-after-links branch from a37107f to 4c24e98 Compare July 21, 2026 01:44
yahonda added a commit to yahonda/docs that referenced this pull request Jul 21, 2026
These lines are also touched by the other open ja PRs (pingcap#23272/pingcap#23273/pingcap#23274/pingcap#23275).
Each PR previously applied only its own fix, so whichever merged second would
conflict. Apply the union of the fixes (stray-digit removal + particle insertion)
so every branch produces identical text and merges cleanly in any order.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yahonda and others added 22 commits July 29, 2026 11:49
…ngCAP Support)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ingCAP Support)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ega file)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… separate PR)

The particle-after-link fix on this line was entangled with an
out-of-scope API-name formatting change (TiDB OperatorAPI -> TiDB
Operator API). Reverting here; both are handled together in the
dedicated API-name PR to keep this PR link-particle only.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The particle-after-link heuristic wrongly inserted を after links whose
text is itself a full verb phrase (e.g. [バグを報告する](...support),
[サポートを受ける](/support.md)), producing ungrammatical
"<verb>を<verb>" text such as "報告するを参照" and even "をください".
Revert those を to base on ~48 lines; the redundant-trailing-verb rewrite
of these support/report links is handled by a separate dedicated PR. The
legitimate particle after noun links on the same lines (e.g. after
[MySQLとの互換性]) is kept.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@yahonda

yahonda commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

Conflicts have been addressed.

yahonda and others added 3 commits July 29, 2026 14:22
Line-by-line review against the English release-8.5 source found three
lines whose earlier repair left ungrammatical or garbled text:
- clinic-introduction / troubleshoot-data-inconsistency: [サポートを受ける]
  followed by 選択/利用 read wrong; EN is just "you can get support" ->
  [サポートを受ける](/support.md)ことができます.
- external-storage-uri: add dropped を after [IAMロール], and rewrite the
  garbled trailing external-ID sentence to match the English.
Applied byte-identically in pingcap#23273 and pingcap#23274.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Keeps this line byte-identical with the fix in pingcap#23274 so the two PRs do
not conflict on functions-and-operators/bit-functions-and-operators.md.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…lease-7.4.0

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-07-29 14:04:35.037150743 +0000 UTC m=+2018461.073245789: ☑️ agreed by qiancai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants